registry icon indicating copy to clipboard operation
registry copied to clipboard

Typings for protobuf.js, bytebuffer.js, long.js

Open MeirionHughes opened this issue 8 years ago • 2 comments

https://github.com/dcodeIO/ProtoBuf.js/ https://github.com/dcodeIO/ByteBuffer.js/ https://github.com/dcodeIO/Long.js/

protobuf.js depends on bytebuffer.js bytebuffer.js depends on long.js

MeirionHughes avatar May 24 '16 08:05 MeirionHughes

typings for these are currently on dt, but there are a few issues with them; like duplicate definition or Long (in bytebuffer) and incorrect use of ByteBuffer (has a smaller mock) in ProtoBuf. Plus the module export is simply wrong in ByteBuffer (exports namespace rather than class which doesn't transpile to an module dependency).

I have fixed these locally, but don't want to change them on dt (presumably they work for someone). Would you accept PR of my local fixes to add these typings to this registry?

MeirionHughes avatar May 25 '16 07:05 MeirionHughes

Of course!

unional avatar May 25 '16 07:05 unional