acquia-php-sdk-v2 icon indicating copy to clipboard operation
acquia-php-sdk-v2 copied to clipboard

Published 20 hours ago • verified publisher icon typhonius

Update scrutinizer

Open danepowell opened this issue 10 months ago • 2 comments

Builds are failing and I'm wondering if updating PHP / Composer will help.

danepowell avatar Apr 16 '24 22:04 danepowell

Updating PHP didn't help but I think logging into Scrutinizer so it could use my GitHub token to bypass rate limits may have done the trick.

danepowell avatar Apr 16 '24 22:04 danepowell

@typhonius can you make me an admin in Scrutinizer so I can figure out why it's failing? It's using an ancient version of PHPCodeSniffer for some reason.

Or else can we just disable Scrutinizer? I don't know what value it provides over what we could already do in GitHub Actions with PHPCS, PHPStan, etc

danepowell avatar Apr 16 '24 23:04 danepowell

danepowell

@typhonius can you make me an admin in Scrutinizer so I can figure out why it's failing? It's using an ancient version of PHPCodeSniffer for some reason.

Or else can we just disable Scrutinizer? I don't know what value it provides over what we could already do in GitHub Actions with PHPCS, PHPStan, etc

Have added you as an admin in scrutinizer. I don't think it's super necessary anymore to be honest. I think I added it in the first place because it was nice to have a badge on the readme that was green.

typhonius avatar May 27 '24 05:05 typhonius

No matter what I tried Scrutinizer kept trying to install an ancient version of PHPCS which broke in PHP 8.2

Finally in the UI I found an undocumented option on the "open source analysis tools config" tab to upgrade PHPCS and that fixed it.

I'll let it slide this time but if it keeps giving us grief I vote to disable scrutinizer.

danepowell avatar May 28 '24 22:05 danepowell