pace icon indicating copy to clipboard operation
pace copied to clipboard

error on client when it tries to connect

Open PCAssistSoftware opened this issue 5 years ago • 6 comments

image

PCAssistSoftware avatar Jul 27 '19 17:07 PCAssistSoftware

I just compiled from master on VS2017 and it works fine

Did you make any changes to the source before compiling? Which IDE did you use to compile, and did it fetch all of the dependency packages?

Keep in mind that this RAT is still in very early development stages and is basically just a client-server framework with basic GUI at this stage. There are virtually no useful features yet, so unless you plan to fork and develop your own extensions, it's better to wait for development and use a more complete RAT for your needs such as Quasar or a paid alternative

fragtion avatar Jul 28 '19 12:07 fragtion

Using VS2019 running on Windows 10 64-bit

Client running on Windows 7 virtual PC running in VirtualBox

No changes made, and yes all dependencies fetched as it builds fine

Noted, was just testing several RAT's and liked your GUI

PCAssistSoftware avatar Jul 28 '19 12:07 PCAssistSoftware

tried it again several times with same issue. here is full text of error message:-

[DEBUG]: Waiting for Server... [DEBUG]: Connected! [DEBUG]: Packet received.

Unhandled Exception: System.NullReferenceException: Object reference not set to an instance of an object. at Pace.Client.System.SystemInformation.GetProductName() in C:\Users\darre\Do wnloads\remote\RATs\pace-master\pace-master\Pace.Client\System\SystemInformation .cs:line 30 at Pace.Client.System.SystemInformation.Get() in C:\Users\darre\Downloads\rem ote\RATs\pace-master\pace-master\Pace.Client\System\SystemInformation.cs:line 17

at Pace.Client.Handlers.SystemHandlers.HandleGetSystemInfo(PaceClient client, IPacket packet) in C:\Users\darre\Downloads\remote\RATs\pace-master\pace-master \Pace.Client\Handlers\SystemHandlers.cs:line 16 at Pace.Client.Network.PacketChannel.HandlePacket(PaceClient client, IPacket packet) in C:\Users\darre\Downloads\remote\RATs\pace-master\pace-master\Pace.Cli ent\Network\PacketChannel.cs:line 23 at Pace.Client.Program.Run() in C:\Users\darre\Downloads\remote\RATs\pace-mas ter\pace-master\Pace.Client\Program.cs:line 45 at Pace.Client.Program.Main(String[] args) in C:\Users\darre\Downloads\remote \RATs\pace-master\pace-master\Pace.Client\Program.cs:line 18

PCAssistSoftware avatar Jul 28 '19 13:07 PCAssistSoftware

Problem fixed

In SystemInformation.cs you are assuming that the client is running on a 64-bit version of Windows and looking in a key which only exists in 64-bit

e.g.

private static string GetProductName() { var key = @"SOFTWARE\Wow6432Node\Microsoft\Windows NT\CurrentVersion"; return Registry.LocalMachine.OpenSubKey(key).GetValue("ProductName").ToString(); }

That is what causes the crash above

For testing I change it to below and it works, but it really needs changing to detect 32 or 64 and then look in correct key

private static string GetProductName() { var key = @"SOFTWARE\Microsoft\Windows NT\CurrentVersion"; return Registry.LocalMachine.OpenSubKey(key).GetValue("ProductName").ToString(); }

PCAssistSoftware avatar Jul 28 '19 13:07 PCAssistSoftware

P.S. when you do "take screenshot" - where does it put it? as can't find where it is saving them or what it does with them. This is one feature I am interested in as most of the others like Quasar don't seem to do screenshots

PCAssistSoftware avatar Jul 28 '19 14:07 PCAssistSoftware

Hey nice work finding the bug for x86 I'm guessing the screenshot function isn't fully implemented yet.. also couldn't find the output myself xD PS It's not my project I'm just subscribed to watch list updates etc ;) I agree the interface is simplistic, modern, and clean. This project has great potential, hopefully we'll see it grow and evolve into something great :)

fragtion avatar Jul 28 '19 15:07 fragtion