Boolean variables in dataflow

[smillst]

trafficstars

This is a rough draft of the fix for #406. @jyoo980 can you see if this fixes the error in the case study? Fixes #406.

[jyoo980]

Testing on the case study now.

On Jun 6, 2024, at 1:04 PM, Michael Ernst @.***> wrote:

@mernst approved this pull request.

LGTM

— Reply to this email directly, view it on GitHub https://github.com/typetools/checker-framework/pull/6661#pullrequestreview-2103103771, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFZ3EEHANMZRUPQQEH5WXVTZGC6ELAVCNFSM6AAAAABI5LZLX2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCMBTGEYDGNZXGE. You are receiving this because you were mentioned.

[jyoo980]

@smillst @mernst It looks like this eliminates the need for inlining boolean expressions in the case study

[msridhar]

This is a really cool PR! Is there any idea what the performance impact will be? In NullAway, local type inference is one of the most expensive parts of checking, and I imagine the same could be true with the Checker Framework. Might be worth doing some sanity checks on large programs to make sure this doesn't lead to a significant regression.

[smillst]

There are bugs in this implementation that once fixed cause infinite recursion, so I'm closing this pull request in favor of https://github.com/typetools/checker-framework/pull/6797