checker-framework icon indicating copy to clipboard operation
checker-framework copied to clipboard

Should the default stub of JUnit asserts like assertNotNull really be NotNull?

Open agentgt opened this issue 4 months ago • 5 comments

I am aware of checker/src/main/java/org/checkerframework/checker/nullness/permit-nullness-assertion-exception.astub

But I have to seriously wonder why the default is not the above particularly since JUnit does not actually throw NPE on assertNotNull but rather a junit specific assertion exception?

It seems like this would hurt uptake of the library and doesn't really offer any advantage. I also could not find the junit4 astub so is this a blanket of all methods named assertNotNull?

I have feeling this has probably been discussed before but I just could not find it.

agentgt avatar Mar 01 '24 19:03 agentgt