Replace Any::Moose with Moo

[melo]

This is a work-in-progress branch, it's not complete, but the test suite passes.

Any::Moose is deprecated. It's no longer recommended. The upgrade path is Moo, it has the same low-overhead of Mouse (actually a bit better) and a better upgrade path to Moose.

I've replaced Any::Moose with the equivalent Moo calls in this branch. The ::Types are gone, and I've moved the coercions inline.

What's missing: all isa checks are disabled for now, I'm not sure what to do here. I could enable them again, with custom checks, but I'm not sure if this is something we should invest on.

Comments? Suggestions?

[typester]

I basically agree with replacing Any::Moose to Moo. And your code seems good, thanks!

I also think that we don't have to re-implement isa checks. It is handy feature and I like it but it causes a bit runtime cost. You might want to implement isa checks for user related attributes, such as hostspec, but I think it's not necessary for other internal attributes.

[melo]

I'll try and work on it a bit more latter today, and fix the isa checks for user related attrs.

Thanks for the feedback.

[zltyfsh]

Hi.

I've done some additional work on top Melo's fork to further improve the transition to Moo (see the pull request.

Is there any plan to go forward with the transition to Moo? It's been a long time since Melo's pull request now.

[bbeeley]

I haven't had any luck with pull requests and this repo. For production use at Say, we have been using our own fork of the repo here:

https://github.com/saymedia/AnyEvent-Gearman

[nponeccop]

Any progress on this?

[melo]

I haven't had the time to work on this... We could probably look at the @bbeeley code and merge that if the test suite passes, given that the code is being tested in a production environment.