anyevent-gearman-perl
anyevent-gearman-perl copied to clipboard
make dist is broken
The MANIFEST file contains 5 files which are not regenerated by auto_include
from Makefile.PL:
inc/Module/Install/Repository.pm
inc/Module/Install/TestBase.pm
inc/Test/Base/Filter.pm
inc/Test/Builder.pm
inc/Test/Builder/Module.pm
Apparently the following patch to Makefile.PL fixes the "problem":
diff --git a/Makefile.PL b/Makefile.PL
index 9f69a22..3764f67 100644
--- a/Makefile.PL
+++ b/Makefile.PL
@@ -9,15 +9,15 @@ requires 'MouseX::Foreign';
requires 'Object::Event' => '1.0';
requires 'Object::Container' => '0.03002';
-test_requires 'Test::More' => '0.92';
test_requires 'Test::Exception';
test_requires 'Test::Deep';
-test_requires 'Test::Base';
test_requires 'Test::TCP' => '0.08';
tests('t/*.t');
author_tests('xt');
+use_test_base;
+auto_set_repository;
auto_include;
However I'm not sure which way to fix the problem is better (the current Makefile.PL fixed by changing the MANIFEST or the patched Makefile.PL with the current MANIFEST)
Just to clarify, the bug is fixed in my nponeccop/anyevent-gearman-perl@all-fixes branch with https://github.com/typester/anyevent-gearman-perl/commit/0765ea6d51faf5e38c368fbb7c4346cff6ad8ef1