routing-controllers icon indicating copy to clipboard operation
routing-controllers copied to clipboard

question: Is this project dead?

Open martin-homer opened this issue 2 years ago • 8 comments

It has been almost a year and a half since the latest release. There are a bunch of outdated dependencies.

Should we migrate away from routing-controllers? any alternative?

Thanks

martin-homer avatar Jul 01 '22 20:07 martin-homer

There's an active issue here: https://github.com/typestack/routing-controllers/issues/783. You could switch to the PR that solves the deps for the time being

FrancisBehnen avatar Jul 11 '22 10:07 FrancisBehnen

@node-decorators/express looks like a good alternative. Not quite as full-featured, but something to build on for sure

pezholio avatar Jul 13 '22 15:07 pezholio

@martin-homer Ist he outdated dependencies resulting an issue?

Its a great lightweight library thats too bad there are no recent updates, however it seems it did achieved its goal making a lean decorator-based version of express, with validations etc.

Is there a concrete feature/bug that you are looking forward to?

There is NestJS which also offers using controllers with Decorators however it is a whole framework that offers a comprehensive solution (much more heavy compared to routing-controllers, therefore can be an overkill).

@pezholio Seems very similar, however I noticed it is not maintained for more than a year and way behind routing-controllers so I would suggest better skipping this one.

aviranco avatar Jul 25 '22 13:07 aviranco

@aviranco yes, this is an issue for us because of outdated dependencies with known vulnerabilities.

We have other dependencies that also use class-validator but we can't update to newer versions (conflicts). As far as our usage, this routing-controllers feature complete and we wouldn't like to switch to other alternatives.

NestJS is what inspired us to choose routing-controllers but migrating to it is a larger effort.

ghost avatar Jul 29 '22 20:07 ghost

Is there any possibility to use/define a custom validator?

teddybee avatar Aug 07 '22 23:08 teddybee

Really seems dead, lots of security problems with peer dependencies that are not updated, :(

mlois-efimob avatar Aug 12 '22 19:08 mlois-efimob

Although this seems to me a great project, I have migrated to Ts.ED and so far it seems to me a great lightweight alternative.

borjapazr avatar Aug 30 '22 11:08 borjapazr

Can someone recommend one that would have the lowest migration effort / most similar annotations?

leonardlin avatar Sep 14 '22 08:09 leonardlin

Can someone recommend one that would have the lowest migration effort / most similar annotations?

I recently migrated routing-controllers to Ts.ED in a template I developed. Here I summarize my experience, but in summary, it was inexpensive and I gained a lot from the change.

borjapazr avatar Oct 04 '22 22:10 borjapazr

Can someone recommend one that would have the lowest migration effort / most similar annotations?

I created a fork with updated dependencies. Issues like #783 is fixed. It's published as routing-controllers-extended and is ready to use. The migration effort is very low.

spicemc avatar Nov 12 '22 17:11 spicemc

Can someone recommend one that would have the lowest migration effort / most similar annotations?

I created a fork with updated dependencies. Issues like #783 is fixed. It's published as routing-controllers-extended and is ready to use. The migration effort is very low.

uiii! can't wait to try, thanks so much

leonardlin avatar Nov 12 '22 17:11 leonardlin

Am I the only one thinking TsEd is a bit too much? I mean, looks great but it feels overengineered. I will move to the fork.

sentientmachin3 avatar Nov 19 '22 12:11 sentientmachin3

Am I the only one thinking TsEd is a bit too much? I mean, looks great but it feels overengineered. I will move to the fork.

I thought the same as you, but I did the migration to Ts.ED and it is very simple and does not add too much complexity.

Here you can find a template for creating a production-ready REST API using Ts.ED.

borjapazr avatar Nov 19 '22 14:11 borjapazr

Same here, also moved to tsed. Just do not forget to implement the class-validator middleware as provided in the sample. I think if there is a fork, that is much easier. It was quite some work to understand all the differences between the projects. I needed to switch from esbuild to swc to get tsed working on an acceptable compilation speed for debugging. Also i needed to implement some custom decorator to minic the ip address decorator from this project and to get the current user i needed to modify the authenicator middleware. That said, tsed is a very nice project, with lots of possibilities. Verstuurd vanaf mijn iPhoneOp 19 nov. 2022 om 15:15 heeft Borja Paz Rodríguez @.***> het volgende geschreven:

Am I the only one thinking TsEd is a bit too much? I mean, looks great but it feels overengineered. I will move to the fork.

I thought the same as you, but I did the migration to Ts.ED and it is very simple and does not add too much complexity. Here you can find a template for creating a production-ready REST API using Ts.ED.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>

air2 avatar Nov 19 '22 15:11 air2

Same here, also moved to tsed. Just do not forget to implement the class-validator middleware as provided in the sample. I think if there is a fork, that is much easier. It was quite some work to understand all the differences between the projects. I needed to switch from esbuild to swc to get tsed working on an acceptable compilation speed for debugging. Also i needed to implement some custom decorator to minic the ip address decorator from this project and to get the current user i needed to modify the authenicator middleware. That said, tsed is a very nice project, with lots of possibilities. Verstuurd vanaf mijn iPhoneOp 19 nov. 2022 om 15:15 heeft Borja Paz Rodríguez @.***> het volgende geschreven:

Am I the only one thinking TsEd is a bit too much? I mean, looks great but it feels overengineered. I will move to the fork.

I thought the same as you, but I did the migration to Ts.ED and it is very simple and does not add too much complexity. Here you can find a template for creating a production-ready REST API using Ts.ED.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>

What do you mean don't forget to implement the class-validator middleware? By default Ts.ED uses AJV to perform automatic validation. But you can use class-validator if you want.

borjapazr avatar Nov 19 '22 16:11 borjapazr

Can someone recommend one that would have the lowest migration effort / most similar annotations?

I created a fork with updated dependencies. Issues like #783 is fixed. It's published as routing-controllers-extended and is ready to use. The migration effort is very low.

routing-controllers-openapi has been migrated to routing-controllers-extended too.

https://www.npmjs.com/package/routing-controllers-extended-openapi

leonardlin avatar Nov 23 '22 17:11 leonardlin

No, the project is not dead. It just needs a little love. I know it was a bit miscommunicated but here's a thread from NoNameProvided: https://github.com/typestack/class-validator/issues/1775 or https://github.com/typestack/typedi/issues/391

@spicemc Would you consider creating a PR from your fork? There are some additional enhancements that need to imlpemented but the release cycles should be smoother from now on. (Hopefully)

attilaorosz avatar Nov 23 '22 19:11 attilaorosz

@spicemc Would you consider creating a PR from your fork? There are some additional enhancements that need to imlpemented but the release cycles should be smoother from now on. (Hopefully)

Sure, i'll create a PR.

spicemc avatar Nov 24 '22 17:11 spicemc

No, the project is not dead. It just needs a little love. I know it was a bit miscommunicated but here's a thread from NoNameProvided: typestack/class-validator#1775 or typestack/typedi#391

@spicemc Would you consider creating a PR from your fork? There are some additional enhancements that need to imlpemented but the release cycles should be smoother from now on. (Hopefully)

thanks @attilaorosz ! Closing this one

ghost avatar Dec 08 '22 13:12 ghost

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

github-actions[bot] avatar Jan 08 '23 00:01 github-actions[bot]