routing-controllers icon indicating copy to clipboard operation
routing-controllers copied to clipboard

build(deps): bump class-transformer and class-validator version

Open gtpan77 opened this issue 3 years ago • 4 comments

Description

Version bump of peer dependencies class-transformer and class-validator. Resolves https://github.com/typestack/routing-controllers/issues/783

Checklist

  • [x] the pull request title describes what this PR does (not a vague title like Update index.md)
  • [x] the pull request targets the default branch of the repository (develop)
  • [x] the code follows the established code style of the repository
    • npm run prettier:check passes
    • npm run lint:check passes
  • [ ] tests are added for the changes I made (if any source code was modified)
  • [ ] documentation added or updated
  • [x] I have run the project locally and verified that there are no errors

Fixes

fixes #783

gtpan77 avatar Jan 12 '22 17:01 gtpan77

@NoNameProvided do you mind giving this a review/merge when you get a chance? This is unfortunately breaking ci for a number of users.

DAlperin avatar Apr 29 '22 02:04 DAlperin

@NoNameProvided Hey! If you can take a look since this version of class-validator includes a very important stopAtFirstError validation setting that is not possible to activate with routing-controllers at the moment. Thanks! :)

biton-ron avatar May 08 '22 08:05 biton-ron

@attilaorosz @NoNameProvided

pfgallagher avatar Jun 08 '22 17:06 pfgallagher

Would it be an idea to publish a version with bumped dependencies to another NPM registry? I'm trying to use this branch, but running into issues because the typescript is not transpiled to javascript if I use the repo directly. https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-npm-registry

FrancisBehnen avatar Aug 05 '22 12:08 FrancisBehnen

Closing this as it is addressed already in a different PR

attilaorosz avatar Dec 09 '22 08:12 attilaorosz

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

github-actions[bot] avatar Jan 09 '23 00:01 github-actions[bot]