routing-controllers icon indicating copy to clipboard operation
routing-controllers copied to clipboard

question: why using yarn.lock and package-lock.json?

Open calmonr opened this issue 3 years ago • 1 comments

I was writing a PR and I noticed that the repository has both t he yarn.lock and package-lock.json file. Is there a reason for that? I'm not 100% sure but I don't think this is recommended (https://classic.yarnpkg.com/blog/2018/06/04/yarn-import-package-lock/)

We highly recommend you to delete the package-lock.json file if you decide to use yarn in order to avoid future confusion and possible consistency issues

For some reason I'm not able to use yarn to install dependencies, I'm getting There appears to be trouble with your network connection. Retrying... and ETIMEDOUT.

I'd be glad to send a PR to remove it if the maintainers wants to keep it consistent with only one package manager.

Thank you.

Update 1:

I was able to get rid the Yarn problem by removing it (yarn.lock) and running yarn import. That is why I don't think using two lock files would help much as they can get out of sync pretty easily.

calmonr avatar Jan 23 '21 13:01 calmonr

cc @pleerock @NoNameProvided @jotamorais

calmonr avatar Apr 02 '21 14:04 calmonr

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

github-actions[bot] avatar Sep 23 '22 00:09 github-actions[bot]