class-validator icon indicating copy to clipboard operation
class-validator copied to clipboard

fix: IsUUID docs is outdated

Open 4strodev opened this issue 1 year ago • 3 comments

Description

Internally it uses validator library and validator supports newer uuid versions. To avoid confusion, docs should be updated.

Expected behavior

Docs show that max supported uuid is v5.

Actual behavior

It actually supports uuid till v8

4strodev avatar Aug 27 '24 09:08 4strodev

PR welcome!

braaar avatar Sep 06 '24 05:09 braaar

I will try to make a PR as soon as possible!. But from my experience in another repos I prefer to first make an issue and if the maintainers allow me then make a PR.

4strodev avatar Sep 06 '24 10:09 4strodev

After checking the dependencies on package.json and the releases of validatorjs. The support of uuid v8 is on master right now on validatorjs. The latest release 13.12. Has support for v1 to v7. Maybe an update could be a good idea. The problem here is that after updating the packages, the test suite fails. I could try to fix the bug. But I prefer to have green light before starting to make the PR.

4strodev avatar Sep 06 '24 10:09 4strodev