class-validator icon indicating copy to clipboard operation
class-validator copied to clipboard
verified publisher icon typestack

fix: handle symbols in constraintToString method with array

Open adrienboulle opened this issue 2 years ago • 4 comments

Description

When implementing custom validators and using array of symbols as constraints, an error is raised when the error message is generated for a failed validation.

Checklist

  • [x] the pull request title describes what this PR does (not a vague title like Update index.md)
  • [x] the pull request targets the default branch of the repository (develop)
  • [x] the code follows the established code style of the repository
    • npm run prettier:check passes
    • npm run lint:check passes
  • [x] tests are added for the changes I made (if any source code was modified)
  • [ ] documentation added or updated
  • [x] I have run the project locally and verified that there are no errors

Fixes

fixes https://github.com/typestack/class-validator/issues/2026

adrienboulle avatar Mar 29 '23 23:03 adrienboulle

@NoNameProvided would you mind having a look at this PR?

adrienboulle avatar Nov 11 '23 20:11 adrienboulle

@braaar would you mind having a look at this PR?

adrienboulle avatar Nov 30 '23 12:11 adrienboulle

hi @braaar I'm having trouble having this PR reviews, let me know if I'm doing anything wrong I would be more than happy to fix it :)

thx a lot!

adrienboulle avatar Jan 22 '24 14:01 adrienboulle

hi @braaar could you review this quick PR ? It's just a following PR regarding this one: https://github.com/typestack/class-validator/pull/1794

adrienboulle avatar Apr 15 '24 08:04 adrienboulle