class-validator icon indicating copy to clipboard operation
class-validator copied to clipboard

ValidationError to extend Error

Open GabCostaSilva opened this issue 3 years ago • 1 comments

Without it is hard to properly test for validations triggered.

Description

Extends the native Error class so the lib is more JS compliance.

Checklist

  • [x] the pull request title describes what this PR does (not a vague title like Update index.md)
  • [x ] the pull request targets the default branch of the repository (develop)
  • [x ] the code follows the established code style of the repository
    • npm run prettier:check passes
    • npm run lint:check passes
  • [ ] tests are added for the changes I made (if any source code was modified)
  • [ ] documentation added or updated
  • [x ] I have run the project locally and verified that there are no errors

Fixes

fixes #[issue number], fixes #[issue number]

GabCostaSilva avatar Aug 11 '22 14:08 GabCostaSilva

could you link this to your issue? fixes #1715

braaar avatar Aug 16 '22 07:08 braaar

Hi @GabCostaSilva! Thanks for the PR, but I have to close this for now. This is the kind of change that seems small at first in reality this needs to be thought through from all aspects.

If the current behavior still causes problems for you we can continue the discussion on the issue.

NoNameProvided avatar Nov 20 '22 13:11 NoNameProvided

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

github-actions[bot] avatar Dec 21 '22 00:12 github-actions[bot]