typesense-docsearch.js icon indicating copy to clipboard operation
typesense-docsearch.js copied to clipboard

fix: react dependency

Open Zamiell opened this issue 8 months ago • 4 comments

Change Summary

Since React 19.1.0 came out, this plugin gives warnings whenever it is installed. This PR attempts to fix this bug.

PR Checklist

Zamiell avatar Jun 20 '25 18:06 Zamiell

@Zamiell Have you tested it on both a React 18 and a React 19 app?

tharropoulos avatar Jul 21 '25 08:07 tharropoulos

well we know it works fine on react 18 because it has been working fine for years. as for react 19, yes, i have tested it on version 19.1.0 and it seems to work fine. the UI still works as before and there are no errors in the javascript console. all this PR will do is clean up the superfluous warnings on npm install. as long as react follows semver (which they do) no minor version should break anything.

Zamiell avatar Jul 21 '25 13:07 Zamiell

:shipit:

tharropoulos avatar Jul 21 '25 15:07 tharropoulos

@tharropoulos Any update on this?

Zamiell avatar Sep 12 '25 21:09 Zamiell