typescript-eslint icon indicating copy to clipboard operation
typescript-eslint copied to clipboard

fix(eslint-plugin): [no-unnecessary-type-parameters] consider type parameter used as rest parameter type to be used multiple times

Open auvred opened this issue 1 year ago • 5 comments

PR Checklist

  • [x] Addresses an existing open issue: fixes #9890
  • [x] That issue was marked as accepting prs
  • [x] Steps in Contributing were taken

Overview

auvred avatar Sep 14 '24 17:09 auvred

Thanks for the PR, @auvred!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

typescript-eslint[bot] avatar Sep 14 '24 17:09 typescript-eslint[bot]

Deploy Preview for typescript-eslint ready!

Name Link
Latest commit e5c5e7385589c9971b2729bd413faa655721db0a
Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/66e5d300e4ecda0008304bde
Deploy Preview https://deploy-preview-9990--typescript-eslint.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse
1 paths audited
Performance: 92 (🔴 down 3 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Sep 14 '24 17:09 netlify[bot]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e5c5e7385589c9971b2729bd413faa655721db0a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

nx-cloud[bot] avatar Sep 14 '24 17:09 nx-cloud[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.67%. Comparing base (77e65df) to head (e5c5e73). Report is 375 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9990   +/-   ##
=======================================
  Coverage   88.67%   88.67%           
=======================================
  Files         425      425           
  Lines       14797    14799    +2     
  Branches     4302     4303    +1     
=======================================
+ Hits        13121    13123    +2     
  Misses       1533     1533           
  Partials      143      143           
Flag Coverage Δ
unittest 88.67% <100.00%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...plugin/src/rules/no-unnecessary-type-parameters.ts 94.36% <100.00%> (+0.08%) :arrow_up:

codecov[bot] avatar Sep 14 '24 18:09 codecov[bot]

Switching to draft per discussion in #9890. Sorry @auvred 😅

JoshuaKGoldberg avatar Sep 16 '24 13:09 JoshuaKGoldberg

Gonna close this, since we ended up closing the backing issue #9890

kirkwaiblinger avatar Feb 08 '25 01:02 kirkwaiblinger