typescript-eslint icon indicating copy to clipboard operation
typescript-eslint copied to clipboard

feat(typescript-estree): make withoutProjectParserOptions generic

Open JoshuaKGoldberg opened this issue 1 year ago β€’ 4 comments

PR Checklist

  • [x] Addresses an existing open issue: fixes #9827
  • [x] That issue was marked as accepting prs
  • [x] Steps in Contributing were taken

Overview

Adds an <Options extends TSESTreeOptions> to withoutProjectParserOptions so it can use types that happen to match it.

πŸ’–

JoshuaKGoldberg avatar Aug 23 '24 22:08 JoshuaKGoldberg

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


πŸ™ Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

typescript-eslint[bot] avatar Aug 23 '24 22:08 typescript-eslint[bot]

Deploy Preview for typescript-eslint ready!

Name Link
Latest commit f873dd434840c096aeeea1e0b0311454e66344bd
Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/66ca11ac86c5570008eb363c
Deploy Preview https://deploy-preview-9877--typescript-eslint.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse
1 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Aug 23 '24 22:08 netlify[bot]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f873dd434840c096aeeea1e0b0311454e66344bd. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

πŸ“‚ See all runs for this CI Pipeline Execution


βœ… Successfully ran 2 targets

Sent with πŸ’Œ from NxCloud.

nx-cloud[bot] avatar Aug 23 '24 22:08 nx-cloud[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.04%. Comparing base (ee38b52) to head (f873dd4). Report is 30 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9877   +/-   ##
=======================================
  Coverage   88.04%   88.04%           
=======================================
  Files         407      407           
  Lines       13948    13948           
  Branches     4078     4078           
=======================================
  Hits        12280    12280           
  Misses       1355     1355           
  Partials      313      313           
Flag Coverage Ξ”
unittest 88.04% <100.00%> (ΓΈ)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Ξ”
...pescript-estree/src/withoutProjectParserOptions.ts 100.00% <100.00%> (ΓΈ)

codecov[bot] avatar Aug 23 '24 23:08 codecov[bot]