typescript-eslint
typescript-eslint copied to clipboard
feat(typescript-estree): stabilize EXPERIMENTAL_useProjectService as projectService
PR Checklist
- [x] Addresses an existing open issue: fixes #9004
- [x] That issue was marked as accepting prs
- [x] Steps in Contributing were taken
Overview
Updates the naming and JSDoc-style comments around:
EXPERIMENTAL_useProjectService: simplifying it to justprojectServiceallowDefaultProjectForFiles: simplifying it toallowDefaultProjectTYPESCRIPT_ESLINT_EXPERIMENTAL_TSSERVER: updates it toTYPESCRIPT_ESLINT_PROJECT_SERVICE
This is in parallel to #8031, which will need to be updated after this.
Also filed a separate #9085 to update the rest of our docs. I think that'll end up needing more discussion, so I'd like to get this in sooner & first.
π
Thanks for the PR, @JoshuaKGoldberg!
typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.
The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.
Thanks again!
π Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.
Deploy Preview for typescript-eslint ready!
| Name | Link |
|---|---|
| Latest commit | af60be8c17303461d475e879c4efccabc7a66fe5 |
| Latest deploy log | https://app.netlify.com/sites/typescript-eslint/deploys/6650599367809400087dd18b |
| Deploy Preview | https://deploy-preview-9084--typescript-eslint.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
Lighthouse |
1 paths audited Performance: 98 (π’ up 6 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports |
To edit notification comments on pull requests, go to your Netlify site configuration.
βοΈ Nx Cloud Report
CI is running/has finished running commands for commit af60be8c17303461d475e879c4efccabc7a66fe5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.
π See all runs for this CI Pipeline Execution
β Successfully ran 32 targets
nx test eslint-plugin --coverage=falsenx test utils --coverage=falsenx run types:buildnx test type-utils --coverage=falsenx test visitor-keys --coverage=falsenx run-many --target=test --parallel --exclude integration-tests --exclude website --exclude website-eslintnx run repo-tools:postinstall-scriptnx test typescript-eslint --coverage=falsenx test scope-manager --coverage=falsenx test eslint-pluginnx test typescript-estree --coverage=falsenx test repo-tools --coverage=falsenx test rule-schema-to-typescript-types --coverage=falsenx test parser --coverage=falsenx test eslint-plugin-internal --coverage=falsenx test utilsnx test type-utilsnx test scope-managernx test visitor-keysnx test typescript-eslintnx test typescript-estreenx run-many --target=lint --parallel --exclude eslint-pluginnx test ast-spec --coverage=falsenx run-many --target=build --parallel --exclude=website --exclude=website-eslintnx test rule-schema-to-typescript-typesnx test parsernx test ast-specnx test repo-toolsnx test eslint-plugin-internalnx run integration-tests:testnx run-many --target=typecheck --parallelnx run repo-tools:generate-configs
Sent with π from NxCloud.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 87.46%. Comparing base (
87a0a48) to head (61a2c83).
:exclamation: Current head 61a2c83 differs from pull request most recent head af60be8
Please upload reports for the commit af60be8 to get more accurate results.
Additional details and impacted files
@@ Coverage Diff @@
## v8 #9084 +/- ##
==========================================
- Coverage 87.46% 87.46% -0.01%
==========================================
Files 387 387
Lines 13117 13116 -1
Branches 3795 3795
==========================================
- Hits 11473 11472 -1
Misses 1354 1354
Partials 290 290
| Flag | Coverage Ξ | |
|---|---|---|
| unittest | 87.46% <100.00%> (-0.01%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Files | Coverage Ξ | |
|---|---|---|
| ...-estree/src/create-program/createProjectService.ts | 76.92% <ΓΈ> (ΓΈ) |
|
| ...eate-program/validateDefaultProjectForFilesGlob.ts | 100.00% <100.00%> (ΓΈ) |
|
| ...pt-estree/src/parseSettings/createParseSettings.ts | 80.28% <100.00%> (ΓΈ) |
|
| ...escript-estree/src/useProgramFromProjectService.ts | 94.28% <ΓΈ> (-0.16%) |
:arrow_down: |
