typescript-eslint
typescript-eslint copied to clipboard
fix(eslint-plugin): [explicit-function-return-types] fix false positive on default parameters
PR Checklist
- [x] Addresses an existing open issue: fixes #8950
- [x] That issue was marked as accepting prs
- [x] Steps in Contributing were taken
Overview
Adds default parameter check analogous to ordinary assignment.
Thanks for the PR, @kirkwaiblinger!
typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.
The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.
Thanks again!
🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.
Deploy Preview for typescript-eslint ready!
| Name | Link |
|---|---|
| Latest commit | cc97e0f902d15ee55bdcb1ae8e15e455e4fbf268 |
| Latest deploy log | https://app.netlify.com/sites/typescript-eslint/deploys/6641c6fc322c5c000871bc38 |
| Deploy Preview | https://deploy-preview-9045--typescript-eslint.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
Lighthouse |
1 paths audited Performance: 99 (🟢 up 3 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports |
To edit notification comments on pull requests, go to your Netlify site configuration.
☁️ Nx Cloud Report
CI is running/has finished running commands for commit cc97e0f902d15ee55bdcb1ae8e15e455e4fbf268. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.
📂 See all runs for this CI Pipeline Execution
✅ Successfully ran 31 targets
nx test eslint-plugin --coverage=falsenx test eslint-pluginnx test visitor-keys --coverage=falsenx test utils --coverage=falsenx run types:buildnx test scope-manager --coverage=falsenx run repo-tools:postinstall-scriptnx test rule-schema-to-typescript-types --coverage=falsenx test typescript-estree --coverage=falsenx test typescript-eslint --coverage=falsenx test type-utils --coverage=falsenx test parser --coverage=falsenx test ast-spec --coverage=falsenx run-many --target=build --parallel --exclude=website --exclude=website-eslintnx test repo-tools --coverage=falsenx test eslint-plugin-internal --coverage=falsenx run-many --target=lint --parallel --exclude eslint-pluginnx test typescript-eslintnx test visitor-keysnx test utilsnx test repo-toolsnx test parsernx test type-utilsnx test typescript-estreenx test rule-schema-to-typescript-typesnx test scope-managernx test eslint-plugin-internalnx run-many --target=typecheck --parallelnx test ast-specnx run integration-tests:testnx run repo-tools:generate-configs
Sent with 💌 from NxCloud.
