typescript-eslint icon indicating copy to clipboard operation
typescript-eslint copied to clipboard

fix(eslint-plugin): remove valid-typeof disable in eslint-recommended

Open JoshuaKGoldberg opened this issue 3 years ago • 4 comments

BREAKING CHANGE: Removes the 'valid-typeof': 'off' line from eslint-recommended.ts, as it's not always covered by TypeScript.

PR Checklist

JoshuaKGoldberg avatar Jul 25 '22 23:07 JoshuaKGoldberg

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

typescript-eslint[bot] avatar Jul 25 '22 23:07 typescript-eslint[bot]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit ffb7f09ea7825decabf34a4faf90ea5b2cce86e0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 24 targets

Sent with 💌 from NxCloud.

nx-cloud[bot] avatar Jul 25 '22 23:07 nx-cloud[bot]

Deploy Preview for typescript-eslint ready!

Name Link
Latest commit ffb7f09ea7825decabf34a4faf90ea5b2cce86e0
Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/635838212f3409000842f463
Deploy Preview https://deploy-preview-5381--typescript-eslint.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Jul 25 '22 23:07 netlify[bot]

Website CI tests failed to download from azure.archive.ubuntu.com. New flake I've never seen before.

Get:138 http://azure.archive.ubuntu.com/ubuntu focal-updates/main amd64 libopengl0 amd64 1.3.2-1~ubuntu0.20.04.2 [29.2 kB]
Fetched 71.3 MB in 14min 51s (80.0 kB/s)
E: Failed to fetch http://azure.archive.ubuntu.com/ubuntu/pool/universe/g/gupnp-igd/libgupnp-igd-1.0-4_0.2.5-5_amd64.deb  Connection failed [IP: 52.252.75.106 80]
E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?
Failed to install browsers
Error: Installation process exited with code: 100

JoshuaKGoldberg avatar Oct 26 '22 14:10 JoshuaKGoldberg