typescript-eslint icon indicating copy to clipboard operation
typescript-eslint copied to clipboard

chore(eslint-plugin): stop linting rule output formatting in tests

Open JoshuaKGoldberg opened this issue 3 years ago β€’ 4 comments

PR Checklist

Overview

Inside the @typescript-eslint/internal/plugin-test-formatting rule, no longer checks formatting for output properties.

Removes noFormat, .trim(), .trimEnd(), and .trimRight() from test outputs.

JoshuaKGoldberg avatar Jul 25 '22 21:07 JoshuaKGoldberg

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 0aa93dec685b0ed524701f382ca23b9648e9e5e6. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

πŸ“‚ See all runs for this branch


βœ… Successfully ran 47 targets

Sent with πŸ’Œ from NxCloud.

nx-cloud[bot] avatar Jul 25 '22 21:07 nx-cloud[bot]

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


πŸ™ Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

typescript-eslint[bot] avatar Jul 25 '22 21:07 typescript-eslint[bot]

Deploy Preview for typescript-eslint ready!

Name Link
Latest commit 0aa93dec685b0ed524701f382ca23b9648e9e5e6
Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/62fcd7d774d1e30008cfb9da
Deploy Preview https://deploy-preview-5379--typescript-eslint.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Jul 25 '22 21:07 netlify[bot]

Codecov Report

Merging #5379 (a9db51d) into main (68e288f) will decrease coverage by 0.23%. The diff coverage is 100.00%.

:exclamation: Current head a9db51d differs from pull request most recent head 0aa93de. Consider uploading reports for the commit 0aa93de to get more accurate results

@@            Coverage Diff             @@
##             main    #5379      +/-   ##
==========================================
- Coverage   93.86%   93.62%   -0.24%     
==========================================
  Files         290      295       +5     
  Lines        9991    10200     +209     
  Branches     3008     3065      +57     
==========================================
+ Hits         9378     9550     +172     
- Misses        332      361      +29     
- Partials      281      289       +8     
Flag Coverage Ξ”
unittest 93.62% <100.00%> (-0.24%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
...lugin-internal/src/rules/plugin-test-formatting.ts 79.85% <100.00%> (ΓΈ)
...s/scope-manager/src/scope/ClassStaticBlockScope.ts 75.00% <0.00%> (-25.00%) :arrow_down:
packages/scope-manager/src/ScopeManager.ts 77.21% <0.00%> (-2.54%) :arrow_down:
...ackages/eslint-plugin/src/rules/no-extra-parens.ts 90.41% <0.00%> (-0.38%) :arrow_down:
.../eslint-plugin/src/rules/no-useless-constructor.ts 95.23% <0.00%> (-0.22%) :arrow_down:
...kages/scope-manager/src/referencer/ClassVisitor.ts 94.01% <0.00%> (-0.11%) :arrow_down:
packages/eslint-plugin/src/rules/no-unsafe-call.ts 100.00% <0.00%> (ΓΈ)
...ackages/eslint-plugin/src/rules/no-explicit-any.ts 92.85% <0.00%> (ΓΈ)
...ackages/eslint-plugin/src/rules/prefer-as-const.ts 100.00% <0.00%> (ΓΈ)
...kages/eslint-plugin/src/rules/naming-convention.ts 81.09% <0.00%> (ΓΈ)
... and 19 more

codecov[bot] avatar Jul 25 '22 23:07 codecov[bot]

image

bradzacher avatar Aug 17 '22 11:08 bradzacher