typescript-eslint icon indicating copy to clipboard operation
typescript-eslint copied to clipboard

feat(typescript-eslint): export util types (close #10848)

Open Mister-Hope opened this issue 9 months ago β€’ 5 comments

PR Checklist

  • [x] Addresses an existing open issue: fixes #10848
  • [x] That issue was marked as accepting prs
  • [x] Steps in Contributing were taken

Overview

This adds export for a namespace TSLint which contain types used in tslint.

The main reason is that as the documentation suggests using tslint stricter types: https://typescript-eslint.io/getting-started#step-2-configuration, people may need to implicitly mark codes to these types in their own flag config, as auto-infer may contain "loose types" (e.g.: string instead of 'a' | 'b') that triggers ts errors.

For examples,see #10848

Mister-Hope avatar Feb 19 '25 05:02 Mister-Hope

Thanks for the PR, @Mister-Hope!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


πŸ™ Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

typescript-eslint[bot] avatar Feb 19 '25 05:02 typescript-eslint[bot]

Deploy Preview for typescript-eslint ready!

Name Link
Latest commit 232f260a37fc07acf73ecd896b8e722adbf1d42e
Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/68da94db61c7f40008b93e97
Deploy Preview https://deploy-preview-10849--typescript-eslint.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse
1 paths audited
Performance: 96 (🟒 up 3 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify[bot] avatar Feb 19 '25 05:02 netlify[bot]

View your CI Pipeline Execution β†— for commit 232f260a37fc07acf73ecd896b8e722adbf1d42e

Command Status Duration Result
nx run-many -t lint βœ… Succeeded 3m 22s View β†—
nx run-many -t typecheck βœ… Succeeded 1m 58s View β†—
nx run integration-tests:test βœ… Succeeded 5s View β†—
nx run types:build βœ… Succeeded 14s View β†—
nx run generate-configs βœ… Succeeded 7s View β†—
nx test eslint-plugin --coverage=false βœ… Succeeded 13s View β†—
nx test eslint-plugin-internal --coverage=false βœ… Succeeded 4s View β†—
nx test typescript-estree --coverage=false βœ… Succeeded 1s View β†—
Additional runs (27) βœ… Succeeded ... View β†—

☁️ Nx Cloud last updated this comment at 2025-09-29 14:24:08 UTC

nx-cloud[bot] avatar Feb 19 '25 05:02 nx-cloud[bot]

Switching this PR to draft pending issue triage.

JoshuaKGoldberg avatar Feb 19 '25 12:02 JoshuaKGoldberg

Noting that this issue is now accepting PRs, so we can unblock this PR.

(thanks to @ntdiary for bringing this to our attention in https://github.com/typescript-eslint/typescript-eslint/issues/10893#issuecomment-2919686555)

kirkwaiblinger avatar May 29 '25 20:05 kirkwaiblinger

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 90.93%. Comparing base (9530e02) to head (232f260). :warning: Report is 36 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10849   +/-   ##
=======================================
  Coverage   90.93%   90.93%           
=======================================
  Files         506      506           
  Lines       51394    51394           
  Branches     8482     8482           
=======================================
  Hits        46735    46735           
  Misses       4646     4646           
  Partials       13       13           
Flag Coverage Ξ”
unittest 90.93% <ΓΈ> (ΓΈ)

Flags with carried forward coverage won't be shown. Click here to find out more.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Sep 29 '25 13:09 codecov[bot]