tslint-to-eslint-config icon indicating copy to clipboard operation
tslint-to-eslint-config copied to clipboard

Core ESLint rules not disabled when their @typescript-eslint equivalent is enabled

Open JamesHenry opened this issue 2 years ago • 4 comments

🐛 Bug Report

  • tslint-to-eslint-config version: 2.13.0
  • ESLint version: N/A
  • Node version: 16.15.0

Actual Behavior

Found when updating angular-eslint's usage of tslint-to-eslint-config

See my minimal repro, e.g. quotes and semi are both enabled despite their typescript-eslint counterparts also being present and enabled.

This is a regression because this didn't use to happen in 2.4.0 which is where I am migrating from (yes I know quite a way behind!)

Expected Behavior

quotes and semi should be explicitly be set to off

Reproduction

Minimal repro here: https://github.com/JamesHenry/tslint-to-eslint-config-repro

  • First commit adds tslint and codelyzer (Angular specific TSLint rules)
  • Second commit is simply the result of running npx tslint-to-eslint-config, see the generated .eslintrc.js

JamesHenry avatar Jun 12 '22 09:06 JamesHenry

This is a continuation of #1207

JamesHenry avatar Jun 12 '22 09:06 JamesHenry

Is this open for contribution? if yes, can I pick it up?

neel-desh avatar Jun 12 '22 16:06 neel-desh

Absolutely, yes please @neel-desh! 🚀

JoshuaKGoldberg avatar Jun 12 '22 17:06 JoshuaKGoldberg

How did you get on @neel-desh?

JamesHenry avatar Jun 23 '22 15:06 JamesHenry

Sorry for taking so long on this @JamesHenry, it fell off my radar! I just tried locally with the latest, [email protected], and get an .eslintrc.js with "quotes": "off" and "semi": "off". Does this issue still repro for you?

JoshuaKGoldberg avatar Oct 13 '22 01:10 JoshuaKGoldberg

Since I made the PR that closed #1207, I checked this out and for me I get the expected behavior in both cases: "quotes: "off", "semi": "off", when running locally and through npx.

hyperupcall avatar Dec 02 '22 03:12 hyperupcall

Great - in that case I'll close this out. Thanks for investigating @hyperupcall!

If anybody is experiencing this behavior as broken, please do post back here or in a new issue with full reproduction steps we can take.

JoshuaKGoldberg avatar Dec 02 '22 16:12 JoshuaKGoldberg