react icon indicating copy to clipboard operation
react copied to clipboard

[Basic] Edit this page button doesn't work for non-docs pages

Open stevemoser opened this issue 2 years ago • 2 comments

What cheatsheet is this about? (if applicable)

Basic cheatsheet

What's your issue or idea?

Edit this page link doesn't work on contributing | React TypeScript Cheatsheets

stevemoser avatar Jul 23 '22 00:07 stevemoser

to clarify the edit button should point to this link https://github.com/typescript-cheatsheets/react/blob/main/CONTRIBUTING.md correct ? @stevemoser

skarthikeyan96 avatar Jul 23 '22 06:07 skarthikeyan96

@sw-yx why are we ignoring contributors.md and contributing.md file ?. Upon investigation Edit page in contributors.md is also pointing to the wrong file.

skarthikeyan96 avatar Jul 23 '22 10:07 skarthikeyan96

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions!

stale[bot] avatar Sep 30 '22 19:09 stale[bot]

@skarthikeyan96 no particular reason, i think we just didnt set it up at the time. happy to take a PR!

swyxio avatar Oct 03 '22 05:10 swyxio

@sw-yx I will be able to create a PR this weekend. Will that be okay ?

skarthikeyan96 avatar Oct 03 '22 12:10 skarthikeyan96

yup! no rush

swyxio avatar Oct 03 '22 16:10 swyxio