typeorm icon indicating copy to clipboard operation
typeorm copied to clipboard

`stream` is ignoring `take` and `skip` with `join`

Open aryelu opened this issue 10 months ago • 0 comments

Issue description

stream is ignoring take and skip

Expected Behavior

Expecting to have the results paginated

Actual Behavior

All rows are returning without pagination

Steps to reproduce

repository.createQueryBuilder('dog')
            .innerJoinAndMapOne('dog.joined', DogJoin, 'joined', 'dog.id = joined.id')
.take(5)
.skip(5)

My Environment

Dependency Version
Operating System
TypeORM version 0.2.41

Additional Context

SelectQueryBuilder with getMany has a particular case for take and skip, while stream doesn't

Relevant Database Driver(s)

  • [ ] aurora-mysql
  • [ ] aurora-postgres
  • [ ] better-sqlite3
  • [ ] cockroachdb
  • [ ] cordova
  • [ ] expo
  • [ ] mongodb
  • [ ] mysql
  • [ ] nativescript
  • [ ] oracle
  • [X] postgres
  • [ ] react-native
  • [ ] sap
  • [ ] spanner
  • [ ] sqlite
  • [ ] sqlite-abstract
  • [ ] sqljs
  • [ ] sqlserver

Are you willing to resolve this issue by submitting a Pull Request?

Yes, I have the time, but I don't know how to start. I would need guidance.

aryelu avatar Apr 10 '24 20:04 aryelu