typeorm
typeorm copied to clipboard
fix: soft deletion should not update the already soft deleted rows
Description of change
Current Behavior
After a soft deletion, if you do a soft delete again with the same condition, it updates the deleted at
column of the previously soft deleted rows as well.
New Behavior
Rows that were already soft deleted previously will be excluded from further soft deletion
Fixes #10389
Pull-Request Checklist
- [x] Code is up-to-date with the
master
branch - [x]
npm run format
to apply prettier formatting - [x]
npm run test
passes with this change - [x] This pull request links relevant issues as
Fixes #10389
- [x] There are new or updated unit tests validating the change
- [ ] Documentation has been updated to reflect this change (N/A)
- [x] The new commits follow conventions explained in CONTRIBUTING.md
I don't understand why this test fails, any help? I can see this failing in several other PRs as well.