GlyphConstruction icon indicating copy to clipboard operation
GlyphConstruction copied to clipboard

add toggle to pause updates in the background

Open cjdunn opened this issue 1 year ago • 9 comments

–Without pausing updates, RF becomes super slow if I want to temporarily work on a glyph without closing this window. –Many times updating a glyph is necessary in the middle of accent building, and I donʻt want to have to always close the GlyphBuilder window and loose my place. –Pausing updates makes it possible to switch to drawing a glyph for a while, or even switch to another typeface for a while, without RF becoming so slow itʻs unusable. –Iʻm sure my code can be improved, and fixes are welcome! Perhaps the checkbox state becomes a preference setting that is saved for next time you open GlyphBuilder (word-o-mat does something like this)? Personally, I would leave this checked maybe 90% of the time.

Thanks @typemytype for considering the PR!

cjdunn avatar Apr 06 '23 17:04 cjdunn

–Just tried this and found out that even running a script to addAnchors runs much faster now, almost runs instantly, with the Pause Updates box checked : )

cjdunn avatar Apr 06 '23 18:04 cjdunn

I renamed to "Pause Observer" to avoid confusion. And I changed the unpause behavior so the window doesnʻt scroll back up to top of window, this was getting annoying

cjdunn avatar Apr 06 '23 18:04 cjdunn

good plan! only the code is really way to complex for what it should do :)

typemytype avatar Apr 06 '23 19:04 typemytype

could you test these changes?

implemented without fiddling around with pauseFonts + renamed it to "Live Updating"

typemytype avatar Apr 07 '23 12:04 typemytype

Thank you!! I’ll give it a try

On Fri, Apr 7, 2023 at 8:02 AM Frederik Berlaen @.***> wrote:

could you test these changes?

implemented without fiddling around with pauseFonts + renamed it to "Live Updating"

— Reply to this email directly, view it on GitHub https://github.com/typemytype/GlyphConstruction/pull/72#issuecomment-1500225902, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA5YGUP2SSMYFVJL6JJAUYLW7765FANCNFSM6AAAAAAWVVZFWY . You are receiving this because you authored the thread.Message ID: @.***>

cjdunn avatar Apr 07 '23 16:04 cjdunn

–Overall looks great, very happy with this!
–Small thing: I noticed that when Live Updates is unchecked, if I change a contour or component and then click back to the window the Glyph Builder drawing updates when I click back to window: good! When I move an anchor, the Glyph Builder drawing doesn't update when I click back to the window. I have to click "Refresh" to see updates from anchor changes. I would expect the anchor change behavior to match contour changes.

Thanks so much!

cjdunn avatar Apr 07 '23 17:04 cjdunn

a complete reload when the window becomes active is a good plan!

typemytype avatar Apr 07 '23 19:04 typemytype

Awesome! That update matches the behavior I expected.

LGTM!

cjdunn avatar Apr 07 '23 22:04 cjdunn

why did you close it?

typemytype avatar Apr 10 '23 15:04 typemytype