funcj icon indicating copy to clipboard operation
funcj copied to clipboard

Published 20 hours ago • verified publisher icon typemeta

Request: Change visibility of various parser fields in `JsonCombParser` to public

Open kpadmasola opened this issue 2 years ago • 5 comments

The JsonCombParser class has various predefined parsers for parsing various JSON types/primitives such as string, boolean, number, digit, hexDigit etc. These definitions are very useful. However, currently they cannot be used externally as their visibility scope is package.

My request is to make them visible with public scope so that consumers of this library can avoid code duplication.

Please let me know if you have any questions/suggestions. Thanks!

kpadmasola avatar Apr 14 '22 06:04 kpadmasola

Done.

jon-hanson avatar Apr 18 '22 12:04 jon-hanson

Great! Could you please bump the version and release the updated library with these changes? Thanks!

kpadmasola avatar Apr 19 '22 04:04 kpadmasola

Hi @jon-hanson Is it possible to release an updated version with these changes? Please let me know if there is something I can do to help with this. Thank you.

kpadmasola avatar Jul 22 '22 07:07 kpadmasola

v0.6.17 is now available.

jon-hanson avatar Aug 29 '22 18:08 jon-hanson

Hmmm, Maven didn't upload any artefacts to Sonatype, weird.

jon-hanson avatar Aug 30 '22 22:08 jon-hanson

Hmmm, Maven didn't upload any artefacts to Sonatype, weird.

Thanks for preparing the release though. What could be the issue causing it? invalid credentials perhaps? Are there build logs that could help identify the root cause?

kpadmasola avatar Sep 02 '22 06:09 kpadmasola

0.6.18 should now be available.

jon-hanson avatar Sep 03 '22 17:09 jon-hanson