typelevel-nix icon indicating copy to clipboard operation
typelevel-nix copied to clipboard

Additional maintainer(s)

Open rossabaker opened this issue 3 years ago • 7 comments

I like to have at least two maintainers on Typelevel projects. This one shouldn't be too burdensome. Volunteers?

rossabaker avatar Feb 02 '22 04:02 rossabaker

As part of https://devenv.sh I added Scala tooling, maybe if you're interested it would be better to maintain it there?

https://github.com/cachix/devenv/pull/60

domenkozar avatar Nov 15 '22 11:11 domenkozar

That's a neat project. There's some nuance in supporting Scala:

  • Which JDK does it build with? Most libraries have one answer, most applications have another.
  • Is Scala.js supported?
  • Is Scala Native supported? What libraries?
  • There's a (declining) tradition of Jekyll sites that we support.

We handle all of that through configuration options. Do you see the devenv language support modules as a starting point, or are you looking to keep them as simple booleans?

rossabaker avatar Nov 15 '22 15:11 rossabaker

We now support a number of java versions: https://devenv.sh/reference/options/#languagesjavaenable

Probably scala should just enable java support as well?

Hopefully that answers your question around configuration options.

domenkozar avatar Nov 19 '22 18:11 domenkozar

That answers my question about whether there's more than languages.whatever.enable.

We generally want our sbt to have a specific JDK, and having Scala Native support implies at least two, usually three extra packages. The C support in devenv is gcc, and we need clang.

So I think that's all to say that it could work, but that to keep parity with what's here, the Scala config would need a lot more options.

rossabaker avatar Nov 21 '22 05:11 rossabaker

I'm happy to move over maintenance if we get a list of the options we need for scala :)

domenkozar avatar Nov 21 '22 11:11 domenkozar

@rossabaker I've made changes so that we add clang and languages.scala.enable now enables languages.java.enable where the SDK can be configured.

domenkozar avatar Jan 19 '23 10:01 domenkozar

There should be proper propagation of jre package now: https://github.com/cachix/devenv/pull/309/files

domenkozar avatar Jan 19 '23 10:01 domenkozar