spire icon indicating copy to clipboard operation
spire copied to clipboard

Ziggurat: Fix an underflow-bug and add a regression test

Open wasowski opened this issue 7 months ago • 1 comments

Fixes #1315. Details of debugging over there.

I added a regression test that fails without the fix to the nfix function. It would be fantastic if this was merged soon, as this would simplify my build management downstream.

wasowski avatar Jun 08 '25 18:06 wasowski

Apparently the regression test is flaky (I could also just remove it). It seems to works fine with the current test suite, but since the Ziggurat implementation is stateful, it may require a higher constant than 975, if another tests presses it. As far as I can see, the regression test will only pass, if some other test fails for this reason, so it does not seem to be a big problem.

wasowski avatar Jun 08 '25 20:06 wasowski