skunk icon indicating copy to clipboard operation
skunk copied to clipboard

Add scala-xml module

Open bplommer opened this issue 3 years ago • 4 comments

bplommer avatar Jun 10 '22 15:06 bplommer

Codecov Report

Merging #664 (89426bb) into main (14c756d) will increase coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #664      +/-   ##
==========================================
+ Coverage   85.02%   85.03%   +0.01%     
==========================================
  Files         124      125       +1     
  Lines        1629     1631       +2     
  Branches       38       38              
==========================================
+ Hits         1385     1387       +2     
  Misses        244      244              
Impacted Files Coverage Δ
modules/scalaxml/src/main/scala/XmlCodecs.scala 100.00% <100.00%> (ø)

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

codecov[bot] avatar Jun 10 '22 15:06 codecov[bot]

Needs mima-wrangling to exclude the new module.

bplommer avatar Jun 13 '22 16:06 bplommer

tlVersionIntroduced := List("2.12", "2.13", "3").map(_ -> "skunk version this will be added").toMap

armanbilge avatar Jun 13 '22 16:06 armanbilge

Note on testing - I've copied the pattern of the Circe tests but they aren't really adequate (they'll still pass if you change the Postgres types of the codecs.) I've done some manual end-to-end testing but we don't have any automated tests that these codecs actually work correctly with Postgres.

bplommer avatar Jun 14 '22 09:06 bplommer