Flesh out Refined module a bit

[LukaJCB]

Looking for some early feedback on this one. Let me know if you have any thoughts on code structure and the like. I removed the NumericCodec file since it looked like a WIP kind of thing.

[tpolecat]

This looks great to me. I like the .refined syntax.

[LukaJCB]

Looks like for some reason refined-cats is not published for 3.x, gonna follow up on their side.

[LukaJCB]

Also pushed a fix for #576 :)

[LukaJCB]

Looks like we ran into the infamous Scala 3.1.x and 3.0.x incompatability 😬

[tpolecat]

Looks like we ran into the infamous Scala 3.1.x and 3.0.x incompatability 😬

Hooray! Is Refined being published on 3.1?

[fthomas]

Yes, it is.

[tpolecat]

@fthomas could Refined be published with 3.0, or does it need stuff introduced in 3.1? I'm not super opposed to upgrading Skunk but I don't want to do it unless I have to.

[fthomas]

I guess it could be published with 3.0 but hasn't the 3.0 ship sailed already? FS2 >= 3.2 is on Scala 3.1 and I guess sooner or later you want to use a newer FS2 version here too.

[tpolecat]

Ok well if FS2 is on 3.1 I guess we can upgrade. Lucky for us nobody is actually using Scala 3 :-P

[LukaJCB]

Updated to Scala 3.1.x and FS2 3.2.x

[codecov-commenter]

Codecov Report

Merging #581 (4a92248) into main (9d3ae9b) will increase coverage by 0.29%. The diff coverage is 40.00%.

@@            Coverage Diff             @@
##             main     #581      +/-   ##
==========================================
+ Coverage   85.63%   85.93%   +0.29%     
==========================================
  Files         124      126       +2     
  Lines        1629     1628       -1     
  Branches       38       38              
==========================================
+ Hits         1395     1399       +4     
+ Misses        234      229       -5     

Impacted Files	Coverage Δ
...main/scala/skunk/refined/codec/RefinedCodecs.scala	33.33% <33.33%> (ø)
...ed/src/main/scala/skunk/refined/codec/Syntax.scala	33.33% <33.33%> (ø)
...main/scala/skunk/refined/codec/RefTypeCodecs.scala	50.00% <50.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9d3ae9b...4a92248. Read the comment docs.

[LukaJCB]

@tpolecat let me know how you'd like to proceed with this one :)

[tpolecat]

Yes, definitely! Mark it as ready for review when you think it's in good shape.

[lenguyenthanh]

Hey, I'm using this code with skunk 0.6.0, and it works great. So, I'm just wondering do we still want this? If yes, I can work on this by cherry pick the commits, and do any further works that are required.

Here is when I use it: https://github.com/lenguyenthanh/lichess-puzzles/blob/main/modules/database/src/main/scala/puzzle/db/Refined.scala

[mpilquist]

@lenguyenthanh Sure, sounds good!