sbt-typelevel icon indicating copy to clipboard operation
sbt-typelevel copied to clipboard

Chop down artifact list in generated ci.yml

Open jeffmay opened this issue 3 years ago • 5 comments

It would make pull requests easier to read if the list of artifacts compressed by tar were chopped down. See this example of a workflow that was converted to hand-written to auto-generated

jeffmay avatar Oct 18 '22 23:10 jeffmay

Thanks for the issue, but some more context/details about what exactly the problem is would be very helpful :)

Edit: a simple before/after example would be very helpful.

armanbilge avatar Oct 18 '22 23:10 armanbilge

Before:

      - name: Compress target directories
        if: github.event_name != 'pull_request' && (startsWith(github.ref, 'refs/tags/v'))
        run: tar cf targets.tar core/target/1-15-jvm-2.13 core/target/1-js-3 core/target/1-js-2.13 joda/target/1-13-jvm-2.12 core/target/1-js-2.12 core/target/1-13-jvm-2.12 core/target/1-15-jvm-2.12 core/target/1-15-js-2.12 joda/target/1-15-jvm-3 joda/target/1-15-jvm-2.13 core/target/1-15-js-2.13 core/target/1-jvm-2.12 joda/target/1-14-jvm-2.13 core/target/1-native-3 target core/target/1-15-jvm-3 core/target/1-15-js-3 joda/target/1-14-jvm-2.12 core/target/1-15-native-3 joda/target/1-jvm-2.13 joda/target/1-15-jvm-2.12 core/target/1-14-jvm-2.12 joda/target/1-jvm-2.12 core/target/1-14-jvm-2.13 core/target/1-jvm-2.13 core/target/1-jvm-3 joda/target/1-jvm-3 core/target/1-15-native-2.13 core/target/1-native-2.13 project/target

After:

      - name: Compress target directories
        if: github.event_name != 'pull_request' && (startsWith(github.ref, 'refs/tags/v'))
        run: |
          tar cf targets.tar \
          core/target/1-13-jvm-2.12 \
          core/target/1-14-jvm-2.12 \
          core/target/1-14-jvm-2.13 \
          core/target/1-15-js-2.12 \
          core/target/1-15-js-2.13 \
          core/target/1-15-js-3 \
          core/target/1-15-jvm-2.12 \
          core/target/1-15-jvm-2.13 \
          core/target/1-15-jvm-3 \
          core/target/1-15-native-2.13 \
          core/target/1-15-native-3 \
          core/target/1-js-2.12 \
          core/target/1-js-2.13 \
          core/target/1-js-3 \
          core/target/1-jvm-2.12 \
          core/target/1-jvm-2.13 \
          core/target/1-jvm-3 \
          core/target/1-native-2.13 \
          core/target/1-native-3 \
          joda/target/1-13-jvm-2.12 \
          joda/target/1-14-jvm-2.12 \
          joda/target/1-14-jvm-2.13 \
          joda/target/1-15-jvm-2.12 \
          joda/target/1-15-jvm-2.13 \
          joda/target/1-15-jvm-3 \
          joda/target/1-jvm-2.12 \
          joda/target/1-jvm-2.13 \
          joda/target/1-jvm-3 \
          project/target \
          target

jeffmay avatar Oct 18 '22 23:10 jeffmay

So by "chopped down" do you mean rendering it on a single line?

armanbilge avatar Oct 18 '22 23:10 armanbilge

@armanbilge

So by "chopped down" do you mean rendering it on a single line?

I am referring to using \ to put each directory on its own line. See the "before" example for what is currently generated and "after" for what I am proposing.

jeffmay avatar Dec 09 '22 19:12 jeffmay

Note that for generated files, it's possible to collapse the diffs entirely with git attributes, which might be a good g8 template addition. See https://medium.com/@clarkbw/managing-generated-files-in-github-1f1989c09dfd.

rossabaker avatar Dec 13 '22 03:12 rossabaker