fs2 icon indicating copy to clipboard operation
fs2 copied to clipboard

Add evalScan1 operator

Open ghostbuster91 opened this issue 3 years ago • 4 comments

Hi,

I needed such operator today and as it wasn't trivial to write it, so I decided to commit it back to the fs2 repository.

ghostbuster91 avatar Mar 15 '22 17:03 ghostbuster91

Sorry this has been sitting for so long 😕 I am going to close/re-open the PR to kick-start CI against the latest main.

armanbilge avatar Jan 03 '23 17:01 armanbilge

@armanbilge No problem, thanks for looking into it :)

ghostbuster91 avatar Jan 03 '23 18:01 ghostbuster91

There is some failing test but I don't think that it is connected:

fs2.concurrent.TopicSuite:
  + subscribers see all elements published 0.042s
==> X fs2.concurrent.TopicSuite.unregister subscribers under concurrent load  0.05s munit.ComparisonFailException: /home/runner/work/fs2/fs2/core/shared/src/test/scala/fs2/concurrent/TopicSuite.scala:114
113:        .map { result =>
114:          assertEquals(result.toMap.size, subs / 2)
115:          assertEquals(result.toMap, expected)
values are not the same
=> Obtained
6
=> Diff (- obtained, + expected)
-6
+5
    at munit.Assertions.failComparison(Assertions.scala:274)
    at flatMap @ fs2.Compiler$Target.flatMap(Compiler.scala:163)
    at flatMap @ fs2.Compiler$Target.flatMap(Compiler.scala:163)

ghostbuster91 avatar Jan 03 '23 19:01 ghostbuster91

Yeah I think that's the known flake ...

  • https://github.com/typelevel/fs2/issues/3071

armanbilge avatar Jan 03 '23 19:01 armanbilge