discipline-scalatest
discipline-scalatest copied to clipboard
Update nscplugin, sbt-scala-native to 0.5.1
About this PR
📦 Updates
from 0.4.17
to 0.5.1
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf
file.
Have a fantastic day writing Scala!
⚙ Adjust future updates
Add this to your .scala-steward.conf
file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scala-native" } ]
Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
pullRequests = { frequency = "30 days" },
dependency = { groupId = "org.scala-native" }
}]
+ Update discipline-core to 1.6.0 + scalacheck-1-16 to scalacheck-1-18 3.2.18.0
LGTM. I'm never 100% sure in these cases if we also need to bump the tlBaseVersion
. It doesn't seem so according to the docs.
@TonioGela , without bumping tlBaseVersion
the MiMa checks fail, because it tries to download older versions compiled with scala-native 0.5, which do not exist.
I feel, the docs are not pretty clear regarding cases like this one. According to the docs this change is more like a binary-breaking one, but that would mean that we would have to bump up the major. Which in turn entails, that we would have to bump majors for all other projects that cross-compile for scala-native, including Cats.
Perhaps, it makes sense to formulate (and formalize) such cases like this one in the docs too. @armanbilge wdyt?
Perhaps, it makes sense to formulate (and formalize) such cases like this one in the docs too.
I agree. FWIW I explained the procedure in the SN 0.5 planning discussion. Basically the reason we should bump the minor in tlBaseVersion
when we go from SN 0.4 to SN 0.5 is so that we can still release patch fixes for the previous series on SN 0.4, just in case.
It looks like we already did the bump in https://github.com/typelevel/discipline-scalatest/commit/a644e1df0b202316ca8bbaa8a936663c000687e2 and have not yet released the 2.3.x series. So this PR should be good to go.
Thanks both for your work!
Thank you @armanbilge for the clarification!
I'd like to schedule the 2.3.0 release pretty soon. Are there any concerns/suggestions on that, just in case?