Add NonEmptyHotswap

[morgen-peschke]

Also corrects the site docs for Hotswap so it conforms to the Hotswap API

Addresses #4268

[kamilkloch]

@djspiewak I know you hate it, but there are so many things we could fix if we just embrace the ugly Hotswap2, Queue2, 😅

sttp has embraced this path a long time ago and it works like a charm :) https://github.com/softwaremill/sttp/tree/master/core/src/main

[morgen-peschke]

@armanbilge did you want the Hotswap2 rename?

[armanbilge]

I do, but I'm not sure if @djspiewak has bought in.

[morgen-peschke]

@djspiewak could we get a ping if this is something you'd like to weigh in on?

[morgen-peschke]

@armanbilge it's been 6 weeks without a ping from @djspiewak, can we take that as "decline to comment" and proceed?

[morgen-peschke]

@armanbilge no shade intended by this question, just want to know if I should close it: is this a dead PR?

[armanbilge]

@morgen-peschke review and release cycles in Cats Effect are often very slow, sorry about that, and thanks for your patience ☺️

[morgen-peschke]

@armanbilge what's the culturally acceptable frequency of comment-bumping a PR in this state?

I'd really like to offload having to remember to check back on this to a repeating calendar event and I also don't want to be a bother by posting too often just to keep the PR from sliding completely off the radar, if the expectation is that this could be another 3+ months.

ETA: In case the above came across wrong, I want to reiterate that no slight is intended, I'm trying to figure out the best way to manage the time and energy I'm going to spend keeping track of this PR, as well as avoid creating the association in y'all's mind as that annoying dev who won't shut up about that one PR.

[morgen-peschke]

@armanbilge the test failure appears to be unrelated to this change, if everything else looks good, can you retrigger CI? If something needs changed, don't worry about it, since it should clear on the next push 🤞🏻

[morgen-peschke]

Is there a reason we moved away from NonEmptyHotswap as a name? Aesthetically that seems better to me than Hotswap2. We could still deprecate Hotswap even in that world.

This isn't something I have strong opinions about, so you'll have to check in with @armanbilge for the reasons behind it.

Context: originally raised in this comment, I swapped the names because it was requested by the primary reviewer, I couldn't think of a good reason not to do it, and I didn't want to hold up the PR.

[armanbilge]

@djspiewak

Aesthetically that seems better to me than Hotswap2.

I don't want to hold this up over aesthetic concerns 😁 if NonEmptyHotswap feels better, let's just do that. To be clear, I still feel strongly that the original Hotswap should be deprecated.

The reason I suggested Hotswap2 is because I think this new API should be Hotswap, not just a different flavor of it. The original Hotswap API is broken, and my personal opinion is the "emptiness" of it is also kind of weird. So describing this new API as the non-empty version of this broken, deprecated API did not sit right with me.