cats-collections icon indicating copy to clipboard operation
cats-collections copied to clipboard

Add cats.kernel.Hash-based CHAMP HashSet

Open DavidGregory084 opened this issue 1 year ago • 3 comments

This is a port of typelevel/cats#4185 to cats-collections.

DavidGregory084 avatar Jul 27 '22 13:07 DavidGregory084

As I understand, it's a latest version from Cats PR, so it's already went through a review regarding code and performance. I have nothing to add to that review, as it's good to go from my point of view.

gemelen avatar Jul 28 '22 10:07 gemelen

That's definitely the case for the HashMap, I think the HashSet (this PR) has had less direct review although I David did a great job applying review feedback from the HashMap also to the HashSet.

If the plans are for cats-collections to 1.0 in the near future (I hope so!) we should make sure everything is carefully reviewed :) I do think this one is in great shape!

armanbilge avatar Jul 28 '22 12:07 armanbilge

Codecov Report

Merging #533 (9fc386e) into master (78f9e4f) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 9fc386e differs from pull request most recent head aaa8a0a. Consider uploading reports for the commit aaa8a0a to get more accurate results

@@      Coverage Diff      @@
##   master   #533   +/-   ##
=============================
=============================

Help us with your feedback. Take ten seconds to tell us how you rate us.

codecov-commenter avatar Aug 02 '22 12:08 codecov-commenter

Is there anything more to be done here? Anything I can do to move this forward?

DavidGregory084 avatar Aug 22 '22 08:08 DavidGregory084