eta icon indicating copy to clipboard operation
eta copied to clipboard

Eta573

Open rajcspsg opened this issue 6 years ago • 4 comments

@rahulmutt - I've updated the changes for the issue eta 573. Looks like I've created PR against wrong branch. could you please let me know the correct branch. I will create different PR against correct branch.

rajcspsg avatar Apr 02 '18 03:04 rajcspsg

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Rajkumar Natarajan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Apr 02 '18 03:04 CLAassistant

Hi @rajcspsg, it looks like you need to update your fork's master to the current master for eta and then make you changes on top of a new branch that starts from the updated master in yor fork.

rahulmutt avatar Apr 02 '18 03:04 rahulmutt

Thanks @rahulmutt. I've updated the PR. Mostly I've updated the class package and refactored the usages of those classes in this PR. Only in this class https://github.com/typelead/eta/pull/721/files#diff-2f5c68896b14fe36169b53a471cd71b9 I've added getter/setters, since the default access modifiers for those fields doesn't let me to use the same in different package.

rajcspsg avatar Apr 02 '18 04:04 rajcspsg

Looks like the build failed: https://circleci.com/gh/typelead/eta/1467?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

Can you make sure you run ./cleaninstall.sh with your changes and made it pass locally?

rahulmutt avatar Apr 02 '18 04:04 rahulmutt