minimal-twitter icon indicating copy to clipboard operation
minimal-twitter copied to clipboard

Fix notification count and red dot not hidden in title

Open Dineshs91 opened this issue 8 months ago • 2 comments

Fix Title Notifications Feature

Updates the title notifications feature to work with the latest X/Twitter favicon naming convention, changing references from twitter.ico to twitter.3.ico and twitter-pip.2.ico to twitter-pip.3.ico. Also adds the title notifications feature to the dynamic features module so it can be toggled at runtime.

When notifications in title is turned off, the feature now properly restores the original favicon by replacing -pip.3 with .3 in the favicon URL.

I am also calling changeNotificationsTitle function from dynamic.js to handle case where notifications show up while I am already active on Twitter/X

Fix MIN-30 and https://github.com/typefully/minimal-twitter/issues/165

Dineshs91 avatar Apr 16 '25 15:04 Dineshs91

[!WARNING] This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite. Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Dineshs91 avatar Apr 16 '25 15:04 Dineshs91

Merge activity

  • Apr 30, 11:26 AM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Apr 30, 11:31 AM EDT: Graphite couldn't merge this pull request because a downstack PR #241 failed to merge.

Dineshs91 avatar Apr 30 '25 15:04 Dineshs91