minimal-twitter icon indicating copy to clipboard operation
minimal-twitter copied to clipboard

In zen mode overflowing content should be scrollable

Open Dineshs91 opened this issue 8 months ago • 2 comments

TL;DR

Changed the body overflow property from hidden to scroll in writer mode.

What changed?

Modified the CSS in the changeWriterMode function to set the body's overflow property to scroll instead of hidden.

How to test?

  1. Enable writer mode in the application
  2. Verify that content can now be scrolled when it exceeds the viewport height
  3. Check that the scrolling behavior works correctly across different content lengths

Why make this change?

The previous overflow: hidden setting prevented users from scrolling through content that exceeded the viewport height in writer mode. This change ensures users can access all content while maintaining the clean writer mode interface.

Fix MIN-31 and https://github.com/typefully/minimal-twitter/issues/169

CleanShot 2025-04-16 at 22.34.55.mp4 (uploaded via Graphite)

Dineshs91 avatar Apr 16 '25 13:04 Dineshs91

This stack of pull requests is managed by Graphite. Learn more about stacking.

Dineshs91 avatar Apr 16 '25 13:04 Dineshs91

Merge activity

  • Apr 30, 11:26 AM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Apr 30, 11:27 AM EDT: Graphite rebased this pull request as part of a merge.
  • Apr 30, 11:31 AM EDT: Graphite couldn't merge this PR because it failed for an unknown reason.

Dineshs91 avatar Apr 30 '25 15:04 Dineshs91