django-stubs icon indicating copy to clipboard operation
django-stubs copied to clipboard

Published 20 hours ago • verified publisher icon typeddjango

SQLCompiler.setup_query - incorrect signature

Open senseysensor opened this issue 1 year ago • 2 comments

Incorrect method signature in stubs

What's wrong

Incorrect signature of SQLCompiler.setup_query() for Django 4.2.5. Signature is specified as following: def setup_query(self) -> None: ...

How is that should be

Actual signature is following: def setup_query(self, with_col_aliases=False):

System information

  • OS: os x 13.5.1
  • python version: 3.11.4
  • django version: 4.2.5
  • mypy version: 1.5.1
  • django-stubs version: 4.2.4
  • django-stubs-ext version: 4.2.2

senseysensor avatar Sep 07 '23 10:09 senseysensor

PR is welcome

sobolevn avatar Sep 07 '23 12:09 sobolevn

I guess this issue should be closed because I see pr has been merged.

nebiyuelias1 avatar Mar 18 '24 01:03 nebiyuelias1

Closed via #1689

flaeppe avatar May 28 '24 20:05 flaeppe