glint icon indicating copy to clipboard operation
glint copied to clipboard

Attempt to use Devin to solve #812

Open NullVoxPopuli opened this issue 11 months ago • 1 comments

Ref #812 By Devin :upside_down_face:

of course there is no test. :see_no_evil:

seeing if it'll make one

With the fix removed, and just the test:


 FAIL  __tests__/transform/template-to-typescript.test.ts > Transform: rewriteTemplate > modifiers > in a conditional expression
Error: Snapshot `Transform: rewriteTemplate > modifiers > in a conditional expression 1` mismatched

- Expected
+ Received

- "__glintDSL__.emitContent(
  __glintDSL__.resolveOrReturn(
    (__glintDSL__.noop(__if),
    __glintRef__.args.onSelect
      ? __glintDSL__.applyModifier(
          __glintDSL__.resolve(__glintDSL__.Globals["on"])(
            __glintY__.element,
            "click",
            __glintRef__.args.onSelect,
          ),
        )
      : null),
  )(),
);
"


+ "__glintDSL__.emitContent(
  __glintDSL__.resolveOrReturn(
    (__glintDSL__.noop(__if),
    __glintRef__.args.onSelect
      ? __glintDSL__.resolve(modifier)(
          __glintDSL__.Globals["on"],
          "click",
          __glintRef__.args.onSelect,
        )
      : undefined),
  )(),
);
"

NullVoxPopuli avatar Mar 15 '25 00:03 NullVoxPopuli

So... now the question is: how close is this to being a correct test?

__glintDSL__.emitContent(
  __glintDSL__.resolveOrReturn(
    (__glintDSL__.noop(__if),
    __glintRef__.args.onSelect
      ? __glintDSL__.applyModifier(
          __glintDSL__.resolve(__glintDSL__.Globals["on"])(
            __glintY__.element,
            "click",
            __glintRef__.args.onSelect,
          ),
        )
      : null),
  )(),
);

NullVoxPopuli avatar Mar 15 '25 00:03 NullVoxPopuli

Closing as this is slop

NullVoxPopuli avatar Oct 30 '25 19:10 NullVoxPopuli