glint icon indicating copy to clipboard operation
glint copied to clipboard

Add template import type for uniqueId helper

Open vstefanovic97 opened this issue 1 year ago • 5 comments

This in combination with https://github.com/DefinitelyTyped/DefinitelyTyped/pull/69687 should make importing uniqueId from @ember/helper work

vstefanovic97 avatar May 27 '24 11:05 vstefanovic97

Why does glint need code changes at all?

NullVoxPopuli avatar May 27 '24 12:05 NullVoxPopuli

Why does glint need code changes at all?

@NullVoxPopuli as far as I can tell the types defined in https://github.com/DefinitelyTyped/DefinitelyTyped/pull/69687/files#diff-ee310ca708dd6726cf0487230fae7935b0eecd94c32c37e022b0776a82506bb7R15 don't have any real type information and we rely on extending the interfaces here in glint

vstefanovic97 avatar May 27 '24 12:05 vstefanovic97

We may need to start a 1.x branch, because main is currently breaking, preparing for v2 / a new approach to glint

NullVoxPopuli avatar May 27 '24 14:05 NullVoxPopuli

This'll be in the main/2.x release (which may be unstable for a while). (looks like you have lint issues though)

We can release this in 1.x if you also make this PR for here: https://github.com/typed-ember/glint/tree/v1.x

NullVoxPopuli avatar Jun 20 '24 15:06 NullVoxPopuli

@NullVoxPopuli I rebased it and repointed to the v1.x branch

vstefanovic97 avatar Jun 26 '24 08:06 vstefanovic97

so sorry to do this, but glint v2 is presently only going to be focused on gjs/gts, which means that we only need be able to use the types from @ember/helper already -- however, those are also broken -- I've opened this issue to track: https://github.com/emberjs/ember.js/issues/20947

NullVoxPopuli avatar Jul 17 '25 14:07 NullVoxPopuli