angular-checklist icon indicating copy to clipboard operation
angular-checklist copied to clipboard

feat: update to Angular v14

Open sheikalthaf opened this issue 3 years ago • 10 comments

In this PR I have update the list of items

  • Updated Angular to latest version (v14)
  • update Ngrx to lastest version (v14)
  • Updated highlight.js to latest version
  • Update Angular universal to inbuilt solution

closes #96 #99

sheikalthaf avatar Nov 08 '21 04:11 sheikalthaf

After upgrading to latest version of highlight.js code highlight is improved.

Before:

image

After:

image

Also added some border radius to avoid sharp edges

sheikalthaf avatar Nov 08 '21 14:11 sheikalthaf

OMG this is awesome <3 Thanks so much for this PR! 🙏

d3lm avatar Nov 09 '21 14:11 d3lm

@sheikalthaf Hey there! Sorry for the silence for so long. I'd love to get this over the finish line. Would you want to upgrade to the latest v14 as well?

d3lm avatar Jun 29 '22 09:06 d3lm

@d3lm updated the PR. Please review the changes

sheikalthaf avatar Jun 30 '22 15:06 sheikalthaf

Thanks so much!

d3lm avatar Jul 04 '22 10:07 d3lm

@santoshyadavdev Can you review the changes as well?

d3lm avatar Jul 04 '22 10:07 d3lm

@santoshyadavdev @d3lm any updates on this PR?

sheikalthaf avatar Jul 16 '22 16:07 sheikalthaf

@d3lm @santoshyadavdev any plan to merge this PR?

sheikalthaf avatar Aug 18 '22 03:08 sheikalthaf

Hi @d3lm can we get this merge.

santoshyadavdev avatar Aug 18 '22 08:08 santoshyadavdev

Yea, I ll have a look again at this PR this week.

d3lm avatar Aug 18 '22 10:08 d3lm

@sheikalthaf When I run the app I am seeing this error now: image The icons in the footer don't work anymore.

d3lm avatar Oct 17 '22 08:10 d3lm

@d3lm Yes, this happens after I moved the fontawesome library icons addition to outside SharedModule constructor (The change has been made after this comment. Yes icons flickers on ssr. There is no official work around it seems link

sheikalthaf avatar Oct 23 '22 18:10 sheikalthaf

@sheikalthaf Hmm, but the icons didn't flicker before 🤔

d3lm avatar Oct 24 '22 10:10 d3lm

Also there seems to be a workaround https://github.com/FortAwesome/angular-fontawesome/issues/48#issuecomment-432543956.

d3lm avatar Oct 24 '22 10:10 d3lm

Also there seems to be a workaround FortAwesome/angular-fontawesome#48 (comment).

@d3lm I tried the workaround and it works. I just can't push commits on the PR to fix it:

.svg-inline--fa {
  vertical-align: -0.125em;
}

fa-icon svg {
  display: inline-block;
  font-size: inherit;
  height: 1em;
}

fa-icon .fa-2x{
  font-size: 2em;
}

geromegrignon avatar Mar 16 '23 12:03 geromegrignon

Oh thanks @geromegrignon. I can try to push this this evening. We may wanna merge this one then, and then update to the latest again? 😅

d3lm avatar Mar 16 '23 12:03 d3lm

yes indeed.

geromegrignon avatar Mar 16 '23 13:03 geromegrignon

@d3lm @geromegrignon sorry for the late response, I'll try to push the changes now

sheikalthaf avatar Mar 18 '23 03:03 sheikalthaf

@d3lm pushed the changes, thanks for the code @geromegrignon

sheikalthaf avatar Mar 18 '23 03:03 sheikalthaf

@d3lm any update on this PR?

sheikalthaf avatar Mar 31 '23 18:03 sheikalthaf

Hi @sheikalthaf, if you are still around, I'm now reviewing the PR as I just joined the team as a maintainer to revive the project.

geromegrignon avatar Jan 29 '24 11:01 geromegrignon