Mark Tyneway

It would be computationally complex for full nodes to compute the filter just to validate a block. Research needs to be done regarding what goes in the filters as well....

> As discussed out of band, I think we should emit events for tree updates as well. PR for emitting tree updates https://github.com/handshake-org/hsd/pull/201, the node websocket topic `"tree commit"`

I don't think the additional i/o introduced by this PR is a problem because it first looks in the `nameview` that is populated in `connectNames` with a database lookup. It...

@aunyks Thank you for the contribution! > Also, should there exist one of these READMEs for every module in lib/? concept ACK on having a README in every module in...

@wi-ski Thanks for your suggestions. What do you think of the edits made to the original post? The API is being structured this way to keep it similar to the...

@pinheadmz bought up a good point, we could rename `opreturn` to `nulldata`. I'm not super opinionated on this. `opreturn` is not part of the Bitcoin spec, you would have to...

You can see the code responsible for creating a DNS response message when a DNS request is sent to the Handshake Zone authoritative server for `.` https://github.com/handshake-org/hsd/blob/155051f7f9af115dc2b8a7bef90963e54e87c5ed/lib/dns/server.js#L227-L283 Notice that if...

> I thought the `key` used to zone-sign and key-sign was from the hard-coded file https://github.com/handshake-org/hsd/blob/155051f7f9af115dc2b8a7bef90963e54e87c5ed/lib/dns/key.js ? That is for DNSSEC, it creates a `RRSIG` RR in the response. That...

After talking to @boymanjor, we are thinking that there should be a clean split between the protocol layer and the DNS application layer. The brontide p2p identity key should NOT...

Note that there are other places in this file that still uses magic numbers, but this was the minimum changes needed to verify that our new simnet params work here...