Mark Tyneway comments

Results 574 comments of


                                            Mark Tyneway

Several blocks with the same tx

Bedrock fixes this issue, won't happen again

feat: Remove contracts-ts in favor of @eth-optimism/constants

Hey @roninjin10 this needs a rebase

config file is not being parsed

I noticed the same thing and was not sure of the best way to go about adding config parsing. There are a bunch of libraries for doing that but I...

feat(ci): Add esm exports to sdk

Perhaps we could merge this after https://github.com/ethereum-optimism/optimism/pull/4778?

feat(ci): Add esm exports to sdk

Just wondering if you are planning on continuing this @roninjin10, would like to help get your code merged

Standard implementation of a custom gas token OP Stack rollup

I would like to understand how the economics of a custom gas token works when you earn in a custom token but then must spend ether to buy gas on...

Standard implementation of a custom gas token OP Stack rollup

We would never accept an implementation without a spec first. If you wanted to open a PR to ethereum-optimism/specs that included exactly how it is implemented, that would be the...

Standard implementation of a custom gas token OP Stack rollup

See https://github.com/ethereum-optimism/specs/issues/67 for a proof of concept implementation

`getDeployedCode` failed to find the code

Try `forge clean` to remove all artifacts and then rebuild. It will build with only 1 version for the particular contract now instead of 2 fwiw the following syntax has...

Add `vm.expectEmitAnonymous` cheatcode to support anonymous events

Wondering if this is being worked on at all as we would like to add some test coverage of anonymous events as part of https://github.com/ethereum-optimism/optimism/pull/10297