jwt-auth icon indicating copy to clipboard operation
jwt-auth copied to clipboard

Laravel 9.x Compatibility

Open laravel-shift opened this issue 3 years ago • 9 comments

This is an automated pull request from Shift to update your package code and dependencies to be compatible with Laravel 9.x.

Before merging, you need to:

  • Checkout the l9-compatibility branch
  • Review all comments for additional changes
  • Thoroughly test your package

If you do find an issue, please report it by commenting on this PR to help improve future automation.

laravel-shift avatar Feb 11 '22 23:02 laravel-shift

:warning: The latest version of Laravel has a dependency for phpunit/phpunit of ^9.3. If you would like to also upgrade your tests, you may run the PHPUnit 9 Shift for free.

laravel-shift avatar Feb 11 '22 23:02 laravel-shift

:warning: Shift detected GitHub Actions which run jobs using a version matrix. Shift attempted to update your configuration for Laravel 9. However, you should review these changes to ensure the desired combination of versions are built for your package.

laravel-shift avatar Feb 11 '22 23:02 laravel-shift

:alembic: Using this package? If you would like to help test these changes or believe them to be compatible, you may update your project to reference this branch.

To do so, temporarily add Shift's fork to the repositories property of your composer.json:

{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/laravel-shift/jwt-auth.git"
        }
    ]
}

Then update your dependency constraint to reference this branch:

{
    "require": {
        "tymon/jwt-auth": "dev-l9-compatibility",
    }
}

Finally, run: composer update

laravel-shift avatar Feb 11 '22 23:02 laravel-shift

FTR, all these necessary changes are part of https://github.com/PHP-Open-Source-Saver/jwt-auth already

mfn avatar Feb 12 '22 07:02 mfn

@mfn, yeah this came in a bit late as we realized some of the automation didn't work for packages where the repository was under a different name.

Feel free to close.

jasonmccreary avatar Feb 12 '22 12:02 jasonmccreary

@jasonmccreary I've no stake / permissions here, can't close :-}

mfn avatar Feb 13 '22 20:02 mfn

+1

mohamed-foly avatar Feb 20 '22 16:02 mohamed-foly

I forked and applied the required updates composer require mohamed-foly/jwt-auth:dev-laravel-9 https://packagist.org/packages/mohamed-foly/jwt-auth#dev-laravel-9

mohamed-foly avatar Mar 04 '22 01:03 mohamed-foly

FTR, as mentioned in https://github.com/tymondesigns/jwt-auth/pull/2168#issuecomment-1037040160 , this is already part of a community fork ❗

mfn avatar Mar 04 '22 09:03 mfn