peario-client icon indicating copy to clipboard operation
peario-client copied to clipboard
verified publisher icon tymmesyde

Fix chat overlap

Open milouk opened this issue 4 years ago • 7 comments

milouk avatar Mar 12 '22 17:03 milouk

Can you show a screenshot of the issue just to make it clearer?

igorcafe avatar Apr 06 '22 16:04 igorcafe

Hi ! Can you separate your changes into different pr ?

tymmesyde avatar May 01 '22 15:05 tymmesyde

Hi ! Can you separate your changes into different pr ?

Done. The reset of the changes where in order to deploy my own version.

milouk avatar May 02 '22 07:05 milouk

Thank you ! I tested these changes but i fail to see what it fixes, it seems to be breaking the chat on mobile

tymmesyde avatar May 09 '22 02:05 tymmesyde

well, after a re-check, the issue should not be present in mobile but it exists in desktop mode.

Here you can see what is currently being deployed. As you can see if anyone opens the chat the movie is being overlapped leading to an either chatting or watching experience Screenshot 2022-05-09 at 10 02 28

With my change this is what happens Screenshot 2022-05-09 at 10 03 43

** Obviously i haven't tested my change in mobile, which as you said is broken

milouk avatar May 09 '22 07:05 milouk

I tested yesterday or so and it was 100% width. Tested today and now it looks like your solution. I believe @tymmesyde fixed it. image

igorcafe avatar May 18 '22 03:05 igorcafe

Hi, I just wanted to tell you that it is still opening fullscreen the chat for me. Tested on 3 diferent devices and browsers.

zaovb avatar Apr 10 '23 01:04 zaovb