Tyler Hughes

Results 185 comments of Tyler Hughes

Also, could you please add a few tests to `tests/test_data/test_data_array.py`? Basically try to replicate a few scenarios and edge cases for this behavior and ensure that the proper thing happens....

It might just be failing because of `direction` coords. but the fix I suggested about `isel`-ing the first coordinate might fix them, so perhaps try that first,

Or it could just be that some of the front end test data arrays have extra coordinates (by accident)

Thanks @marc-flex just FYI, this PR #1681 changed some of the tests in pre/2.7 so it looks like you'll need to rebase against that branch and fix any conflicts that...

@marc-flex @momchil-flex is this something we want to get into 2.7.0rc2? and is it ready or still needing changes?

I agree with @marc-flex . Maybe it's best to just limit the scope of these validators to the components that are causing issues as per #1684 . because I additionally...

@marc-flex I think this is basically ready to go. Last thing you'll need to do is update the docs/notebooks submodule to the latest version (pre/2.7 branch). After you make that...

(make sure your black is the same as the version defined in pyproject.toml, or it will format most of the files in tidy3d)

Thanks @dbochkov-flexcompute. Can you just add a changelog item under fixed and I think this is good to merge and also fixes #1683 as far as I can tell.

@QimingFlex @weiliangjin2021 @dmarek-flex Is this feature planned for 2.7 or 2.8? Also is it still under development? should I mark as a "draft"?