lern icon indicating copy to clipboard operation
lern copied to clipboard

Format email message.

Open sroutier opened this issue 9 years ago • 12 comments

Hello,

Thanks for this great package.

Do you know of a good way to format the email message that is sent? In the "Changing the text" section of your README, you show us how to do some formatting and how to add details but the HTML formatting is not retained. Ideally LERN would make use and publish templates that could be customized.

Any thoughts?

Cheers. /S

sroutier avatar Jun 28 '16 01:06 sroutier

Hey Sebastian, thanks for reaching out. I like the idea of using templates for LERN. Let me get back to you after I've done some digging through the code.

On Mon, Jun 27, 2016, 7:01 PM Sebastien Routier [email protected] wrote:

Hello,

Thanks for this great package.

Do you know of a good way to format the email message that is sent? In the "Changing the text" section of your README, you show us how to do some formatting and how to add details but the HTML formatting is not retained. Ideally LERN would make use and publish templates that could be customized.

Any thoughts?

Cheers. /S

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/tylercd100/lern/issues/33, or mute the thread https://github.com/notifications/unsubscribe/AEUA8rfPu7wnk15Qn93ebp3AEKAW_oU4ks5qQHJZgaJpZM4I_pa7 .

tylercd100 avatar Jun 29 '16 03:06 tylercd100

Hey @sroutier I just saw the package you are working on. What an honor! :)

I'll try an make sure I get this done this week

tylercd100 avatar Jul 26 '16 05:07 tylercd100

Thanks, would be great if email templates could be supported. It would add some polish and customizations. Could not have done it without the great packages created and open-sourced by the community like yourself.

Cheers. /S

sroutier avatar Jul 26 '16 18:07 sroutier

I agree with @sroutier, using an e-mail template would be great.

eleftrik avatar Aug 30 '16 11:08 eleftrik

Hey @sroutier and @eleftrik. I have released version 3.6.5 which allows for html in emails.

I am still going to keep this issue open because I think templates is a great idea. I do however want to see how I can utilize Laravel 5.3's new Email and Notification functionality to see if it would benefit templates in a LERN v4.0 release.

tylercd100 avatar Aug 30 '16 22:08 tylercd100

That is great Tyler. I will look at it ASAP. Thanks a lot. /S

On Tue, Aug 30, 2016 at 6:05 PM, Tyler Arbon [email protected] wrote:

Hey @sroutier https://github.com/sroutier and @eleftrik https://github.com/eleftrik. I have released version 3.6.5 https://github.com/tylercd100/lern/releases/tag/3.6.5 which allows for html in emails.

I am still going to keep this issue open because I think templates is a great idea. I do however want to see how I can utilize Laravel 5.3's new Email and Notification functionality to see if it would benefit templates in a LERN v4.0 release.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tylercd100/lern/issues/33#issuecomment-243596657, or mute the thread https://github.com/notifications/unsubscribe-auth/AC30Fv_F6iqNnNNaTWBWTQ8xBmwirxeTks5qlKlHgaJpZM4I_pa7 .

sroutier avatar Aug 30 '16 22:08 sroutier

Thank you @tylercd100, I will try ASAP

eleftrik avatar Nov 25 '16 09:11 eleftrik

@tylercd100, I tried to use HTML, but I'm still receiving emails with expanded tags. Can you please share an example?

eleftrik avatar Nov 25 '16 09:11 eleftrik

@eleftrik @sroutier I got blade templates working with LERN

Check out the README for the latest version. You will also need to run this line in the terminal if you want to use the default blade template

php artisan vendor:publish --provider="Tylercd100\LERN\LERNServiceProvider"

tylercd100 avatar Nov 28 '16 21:11 tylercd100

@eleftrik It looks like SMTP is not properly setting the email type to HTML for the email, I will get this fixed as soon as I can

tylercd100 avatar Nov 28 '16 21:11 tylercd100

@eleftrik It looks like SMTP is not properly setting the email type to HTML for the email, I will get this fixed as soon as I can

Hi @tylercd100, was this fixed? I tried to upgrade to version 3.8.2, but I'm still receiving text only e-mails, with no line breaks and no HTML format.

Thank you

eleftrik avatar Jul 11 '17 12:07 eleftrik

Now it works! Sorry, I forgot update my config file, adding 'view' => 'exceptions.default',

One last issue: when I receive email, they always start with something like

[2017-07-11 14:55:01] Tylercd100\LERN.CRITICAL:

..and end with two empty arrays: [] []

In resources/exceptions/default.blade.php I'm not priting such arrays.

@tylercd100, have you any suggestion?

Thanks

eleftrik avatar Jul 11 '17 12:07 eleftrik