Tyler Benson

Results 149 comments of Tyler Benson

Add setTag/withTag overloads that accept `io.opentracing.tag` types

@tedsuo @carlosalberto can we consider getting this included into `0.32.0`?

Sanitizing Span Tags

I too would like to see a standardized way of post-processing, but I think it should extend do logs as well, not just tags.

Correct way how to not report fast spans

I don't think most tracing systems will allow this since there is no way to know if a distributed request was made. My suggestion would be to look for a...

Deprecate or remove `ScopeManager.active()`

I'm probably missing something, but I don't understand the problem with that method... Why wouldn't you want a way to get the current scope from the ScopeManager? How would you...

Deprecate or remove `ScopeManager.active()`

After discussing with Adrian in a side channel, I am ok with his proposal to have the return type change. I still think there should be a way to tell...

understand and address concerns with ActiveSpan refcounting

I think part of the confusion is the fact that it isn't really clear how instrumentation is supposed to interact with the continuation model. My understanding of the intent is...

ThreadLocalActiveSpan.deactivate()

Any reason you don't want to activate the span on the new thread and then close it?

Allow Tracer access from Span

Perhaps this should go through as an RFC on the spec first so we have better uniformity across languages?

Can Scopes be extended to carry other context besides Span?

I wonder if there could be benefit in splitting out "scopes" or "context" off into a separate project that can evolve independently from "tracing".

Remove service tag and replace with a similar concept on Scope.

@yurishkuro to be clear, you would prefer @adriancole's second suggestion, to see this associated with the span builder and have it propagated more like baggage?